[PATCH] D65656: AArch64: support @llvm.{return,frame}address in GlobalISel

Tue Jan 21 21:18:17 PST 2020

aemerson added a comment.

In D65656#1830280 <https://reviews.llvm.org/D65656#1830280>, @peter.smith wrote:

> In D65656#1822347 <https://reviews.llvm.org/D65656#1822347>, @aemerson wrote:
>
> > Re-closing.
>
>
> Apologies I've bisected an AArch64 sanitiser buildbot failure down to revision 2e39ea726e9cee20060892705164760229e0cb0b <https://reviews.llvm.org/rG2e39ea726e9cee20060892705164760229e0cb0b>
>  Revert "Revert rG6078f2fedcac5797ac39ee5ef3fd7a35ef1202d5 <https://reviews.llvm.org/rG6078f2fedcac5797ac39ee5ef3fd7a35ef1202d5> - "[AArch64][GlobalISel]: Support @llvm.{return,frame}address selection.""
>  This first started failing http://lab.llvm.org:8011/builders/clang-cmake-aarch64-lld/builds/8015 with fail mails likely suppressed due to a previous failing build.
>
> When I run the test manually I get the output:
>
>   UNCHANGED 'abcdef'
>   EMPTY ''
>   PARTIAL '0x4c3'
>   FIRST_FORMAT 0x4c3694  (/home/peter.smith/llvm/repos/builda64/projects/compiler-rt/test/sanitizer_common/asan-a
>   SECOND_FORMAT FUNC:<null> LINE:0 FILE:<null>
>   LONG_FORMAT LOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO
>   GLOBAL: <null> <null>:0
>
>
> Where the <null> LINE:0: File:<null> are supposed to be // CHECK: SECOND_FORMAT FUNC:main LINE:[[@LINE+1]] FILE:symbolize_pc.cpp
>  It looks like the symboliser is no longer able to find the function.
>  The test is run at -O0 so this will get global-isel on AArch64.
>
> Can you take a look?

Sorry, I missed this email. I'll take a look and do a quick fix if I can (don't have access to a linux machine) or revert if it'll take longer.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65656/new/

https://reviews.llvm.org/D65656