[PATCH] D73129: [LoopUnrollAndJam] Correctly update LoopInfo when unroll and jam more than 2-levels loop nests.

Whitney Tsang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 21 21:00:30 PST 2020


Whitney marked an inline comment as done.
Whitney added a comment.

> Does it make sense to split the cloneBasicBlocksInLoop changes and review them separatly? It would make the diff smaller and easier to read.

Sounds good, I will move all simple changes unrelated to cloneBasicBlocksInLoop to another review.



================
Comment at: llvm/test/Transforms/LoopUnrollAndJam/loopnest.ll:6
+; CHECK-LABEL: foo
+; CHECK: %i = phi i64 [ 0, %entry ], [ %inc.i.3, %for.i.latch ]
+
----------------
jdoerfert wrote:
> I would generate the check lines with the update_checks script. This doesn't test much.
I tried to follow the same pattern as the other unroll and jam lit tests.  The main purpose of this test is to check if loop info verified correctly. I will update the test with check lines generated by use update_checks script.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73129/new/

https://reviews.llvm.org/D73129





More information about the llvm-commits mailing list