[PATCH] D72347: [NFC][XCOFF] Refactor Csect creation into TargetLoweringObjectFile

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 21 15:45:55 PST 2020


hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.

LGTM with minor comment.



================
Comment at: llvm/include/llvm/CodeGen/TargetLoweringObjectFileImpl.h:250
+
+  // For external functions, this will always return a function descriptor
+  // csect.
----------------
I think this deserves to be a Doxygen comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72347/new/

https://reviews.llvm.org/D72347





More information about the llvm-commits mailing list