[PATCH] D72798: [llvm][docs] LangRef for IR attribute `vector-function-abi-variants`.

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/docs/LangRef.rst:1878
+
+         _ZGV<isa><mask><vlen><parameters>_<scalar_name>{(<vector_redirection>)}
+
----------------
fpetrogalli wrote:
> jdoerfert wrote:
> > 1) Only `CallInst` or call site?
> > 2) Do we have a mangling doc entry that we could link to?
> > 3) Do the `{` and `(` belong to the token stream? Maybe `[` is better to indicate optional things?
> 
> > Only CallInst or call site?
> 
> I am not sure what the distinction is. For now we are in need of it only for CallInst. What would be a call site?
> 
> 
> > Do we have a mangling doc entry that we could link to?
> 
> The aarch64 and x86 ones are linked below. For LLVM, this piece of docs is to be considered the mangling doc.
> 
> > Do the { and ( belong to the token stream? Maybe [ is better to indicate optional things?
> 
> I'll use `[` for optional instead of `{`.
> 
> 
> 
Call site is a term (and for now a class `llvm::CallSite`) that describes `CallInst`, `InvokeInst`, `CallBr` (I think), and later potentially other call like instructions. If these attributes can be placed on an `InvokeInst` which I was expecting, we need to say call site or also mention `InvokeInst`. If they cannot, we should mention that explicitly I think.

Also, if you refer to `CallInst` we need the ticks and a link to the definition in the lang ref.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72798/new/

https://reviews.llvm.org/D72798