[PATCH] D73131: [IR] Value::getPointerAlignment(): handle pointer constants

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 21 14:05:51 PST 2020


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM with one suggestion



================
Comment at: llvm/test/Transforms/Attributor/nonnull.ll:531
   ret i32* inttoptr (i64 4 to i32*)
 }
 
----------------
I was about to ask for a test with a `non-null` constant when I saw this. Maybe we should have one more prominently as @test13 above?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73131/new/

https://reviews.llvm.org/D73131





More information about the llvm-commits mailing list