[PATCH] D73071: [X86][test] Add tests for -fpatchable-function-entry=N,M (where M>0) and its interaction with -fcf-protection=branch

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added inline comments.


================
Comment at: llvm/test/CodeGen/X86/patchable-function-entry-ibt.ll:27
+
+;; -fpatchable-function-entry=2,1 -mbranch-protection=bti
+define void @f2_1() "patchable-function-entry"="1" "patchable-function-prefix"="1" {
----------------
Should the filename of this added test be `s/ibt.ll/bti.ll`?


================
Comment at: llvm/test/CodeGen/X86/patchable-function-entry.ll:88
+; NOFSECT     .section __patchable_function_entries,"awo", at progbits,f0,unique,0
+; FSECT:      .section __patchable_function_entries,"awo", at progbits,f3_2,unique,4
+; 32:         .p2align 2
----------------
The comment about `-ffunction-sections` added to the aarch64 test in https://reviews.llvm.org/D73070 would be helpful here, too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73071/new/

https://reviews.llvm.org/D73071