[PATCH] D70762: scudo: Add initial memory tagging support.

Tue Jan 21 12:23:36 PST 2020

pcc marked an inline comment as done.
pcc added inline comments.

================
Comment at: compiler-rt/lib/scudo/standalone/memtag.h:14
+
+#include <sys/auxv.h>
+#include <sys/prctl.h>
----------------
bjope wrote:
> pcc wrote:
> > cryptoad wrote:
> > > If I followed properly `memtag.h` is included on all platforms, but I am not sure `sys/*.h` is available everywhere (Fuchsia doesn't have one).
> > > So this probably requires some `#if SCUDO_LINUX` or something to that extent?
> > Yes, this will need `SCUDO_LINUX`, done.
> I also had to move the auxv include a few lines down (inside the {{#if defined(ANDROID_EXPERIMENTAL_MTE)}} guard) for things to build on my RedHat 6.10 server.
> Would it make sense to do that change upstream?
I don't think so, we will eventually need to include it unconditionally on Linux once ANDROID_EXPERIMENTAL_MTE goes away as mentioned in the commit message. I think it would be better to change the build system so that we don't build/test scudo on Linux machines without a sys/auxv.h.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70762/new/

https://reviews.llvm.org/D70762