[PATCH] D73081: [LICM] Don't cache AliasSetTrackers when run under legacy PM

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 21 09:48:41 PST 2020


asbirlea accepted this revision.
asbirlea added a comment.
This revision is now accepted and ready to land.

Thanks you for taking this on!

Could you add a few more details to the motivation and current state of the codebase, something along the lines:

  LICM has already switched to using MemorySSA to do sinking and hoisting and only builds an AliasSetTracker on demand for the promoteToScalars step, without caching it from one LICM instance to the next. Given this, we don't have compile-time reasons to keep AST caching any more.
  The only scenario where the caching would be used currently is when using the LegacyPassManager and setting -enable-mssa-loop-dependency=false. 




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73081/new/

https://reviews.llvm.org/D73081





More information about the llvm-commits mailing list