[PATCH] D72992: [llvm-objdump] - Add column headers for relocation printing

Tue Jan 21 06:22:00 PST 2020

liadz0rz added a comment.

In D72992#1830736 <https://reviews.llvm.org/D72992#1830736>, @jhenderson wrote:

> In D72992#1830094 <https://reviews.llvm.org/D72992#1830094>, @liadz0rz wrote:
>
> > I've updated the relocations-elf.test file with the new headers, they seem to recognize the headers quite well, however, the relocations on my machine come out different than the test expects, so the other parts of the test fail...
> >  Are there any requirements for the machine I am running my test on?
>
>
> I'm not aware of any specific requirements for this test. How are you running the test? Have you remembered to build the other tools in LLVM that it uses? (yaml2obj, llvm-objdump, FileCheck?). What is the output you get when you run the test?

I ran the tests in 2 ways:

OK I was mistaken, sorry about that, I've fixed the tests so they all contain the headers, 2 notes on that:

1. it seems that the tests do not really test white spaces for some reason (I tried randomly changing the padding in the test to check that, as long as the right words were written in the right order all was well) does it make any sense to you?
2. The web assembly test already contains a 32-bit address, would you like me to add a specific test case for explicit 32-bit for this matter?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72992/new/

https://reviews.llvm.org/D72992