[PATCH] D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 21 03:32:22 PST 2020


ikudrin added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFDebugMacro.h:52
+    //   a 64-bit DWARF format macro section
+    uint32_t DebugLineOffset;
+  };
----------------
Make this field `uint64_t` so that it will be compatible with 64-bit DWARF from the beginning. Changing it later is always more difficult and error-prone.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73086/new/

https://reviews.llvm.org/D73086





More information about the llvm-commits mailing list