[PATCH] D72843: [llvm-readelf][llvm-readobj] - Fix the indentation when printing dynamic tags.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5804
+
+  std::string ValueFmt = "%-" + std::to_string(MaxTagSize) + "s ";
   for (auto Entry : Table) {
----------------
jhenderson wrote:
> Don't know if it really matters, but shouldn't one of these strings be converted to a `Twine`?
It would be
`(Twine("%-") + std::to_string(MaxTagSize) + "s ").str();`
I think the complexity added does not worth it?



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72843/new/

https://reviews.llvm.org/D72843