[PATCH] D70754: [libcxx] Add support for std::reinterpret_pointer_cast

Marshall Clow via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 20 20:13:40 PST 2020

Previous message: [PATCH] D72808: [mlir] [VectorOps] Lowering of vector.extract_slices to LLVM IR
Next message: [PATCH] D70754: [libcxx] Add support for std::reinterpret_pointer_cast
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

mclow.lists added a comment.

You have no tests.
If you had tests, you would probably have noticed that you typed `_UP` when you meant `_Up`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70754/new/

https://reviews.llvm.org/D70754

Previous message: [PATCH] D72808: [mlir] [VectorOps] Lowering of vector.extract_slices to LLVM IR
Next message: [PATCH] D70754: [libcxx] Add support for std::reinterpret_pointer_cast
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list