[PATCH] D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types.

Marcello Maggioni via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 20 19:09:35 PST 2020


kariddi added inline comments.


================
Comment at: mlir/tools/mlir-tblgen/LLVMIRIntrinsicGen.cpp:177
+  for (int idx : overloadedOps) {
+    os << "\n        opInst.getOpOperand(" << idx << ").get().getType()"
+       << ".cast<LLVM::LLVMType>().getUnderlyingType(),";
----------------
rriddle wrote:
> Can you use getOperand instead?
Thanks, good one! I actually missed that we had getOperand() available


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72974/new/

https://reviews.llvm.org/D72974





More information about the llvm-commits mailing list