[PATCH] D72034: [GlobalISel][RFC] Importing patterns with PtrValueType and nullptr

Mon Jan 20 13:59:54 PST 2020

arsenm added a comment.

In D72034#1829684 <https://reviews.llvm.org/D72034#1829684>, @Petar.Avramovic wrote:

> Ping.

I'm going to have to disagree with the change in D44762 <https://reviews.llvm.org/D44762>, and think it should be reverted. null in the IR has the original pointer type, and is not a cast from an integer constant. This presents a problem for non integral address spaces for example, where you are allowed to have a literal null/0 value, but the inttoptr is not allowed. I would prefer if the IR defined a more proper nullptr in the IR that wasn't just a 0 constant, but that's not the current state of the world.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72034/new/

https://reviews.llvm.org/D72034