[PATCH] D72701: [Hexagon] Add support for Linux/Musl ABI.

Sid Manning via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 20 11:50:19 PST 2020


sidneym added a comment.



In D72701#1829811 <https://reviews.llvm.org/D72701#1829811>, @dalias wrote:

> Forgive my jumping into this without knowing all the details, but is there a public intended-for-upstreamability hexagon arch definition for musl? If not, are there assumptions about musl and the libc-defined part of the ABI in this changeset that might depend on or conflict with what's eventually added upstream?


Supporting MUSL didn't require any ABI changes but moving to a Linux OS allowed us to fix some issues in the original ABI.  Just checking for the OS could cause this ABI to be accidentally selected so I used the environment, musl to limit when it could be enabled.
I'm working on getting permission for a public github to host the bits we needed to add to MUSL to support Hexagon.  I thought having a "working" reference to examine and then posting a series of patches for review to the musl-mailing list would be the easiest way to go.  I admit I have not yet reached out the musl mailing list to confirm this because I wanted to have the github repo up first, but how does this plan sound to you?

Thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72701/new/

https://reviews.llvm.org/D72701





More information about the llvm-commits mailing list