[PATCH] D72928: [llvm-exegesis][NFC] Disassociate snippet generators from benchmark runners

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 20 07:05:54 PST 2020


courbet added inline comments.


================
Comment at: llvm/tools/llvm-exegesis/lib/ParallelSnippetGenerator.cpp:42
 // The above snippet will be able to fully saturate the ports, while the same
 // with ax would issue one uop every `latency(IDIV8r)` cycles.
 //
----------------
mstojanovic wrote:
> Should this be reworded similarly to the comment above?
I think this one is fine since we gave ports as an example for resources before. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72928/new/

https://reviews.llvm.org/D72928





More information about the llvm-commits mailing list