[PATCH] D72797: [llvm-dwarfdump][Statistics] Distinguish functions/variables with same name across different CUs

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 20 02:35:12 PST 2020


djtodoro added a comment.

Thanks for doing this!

> So, this increases number of 'total vars' because these 'a' and 'b' variables counted twice.

I see... Can we do something to avoid the additional calculation? Somehow to recognize we already observed the `a` and `b`, although they have different DIE ID.

> I also was a bit optimistic about how this patch(es) affects the performance of the statistics, it actually became two times slower than before the patches.

What patch from the stack adds the overhead? This one?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72797/new/

https://reviews.llvm.org/D72797





More information about the llvm-commits mailing list