[PATCH] D72913: [FileCheck] Make Match unittest more flexible

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/unittests/Support/FileCheckTest.cpp:424
   Tester.initNextPattern();
-  // Check that @LINE is 9 as expected.
+  // Check that @LINE still matches the current line number.
   EXPECT_FALSE(Tester.parsePatternExpect("[[#@LINE]]"));
----------------
To make it clear that @LINE has been updated here, I'd recommend changing this phrase to "Check that @LINE matches the later line number." It might also be worthwhile putting a comment somewhere showing that initNextPattern updates the line number.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72913/new/

https://reviews.llvm.org/D72913