[PATCH] D72454: [AIX] Enable frame pointer for AIX and add related test suite

[Xiangling Liao via Phabricator via llvm-commits]

Xiangling_L marked 13 inline comments as done.
Xiangling_L added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/Frames-alloca.ll:39
+; - Frame pointer register (r31) is saved/defined/restored.
+; - Allocated area is referrd by frame pointer with correct offset.
+; - Allocated area is 4 bytes aligned in the case of int.
----------------
ZarkoCA wrote:
> Xiangling_L wrote:
> > ZarkoCA wrote:
> > > typo: should be `referred`, this happens in other test cases below
> > Thanks. updated it.
> Sorry, I wasn't clear the same typo happens in the other test case files and not only in this one.  I've marked the typos I caught. 
Thank you.


================
Comment at: llvm/test/CodeGen/PowerPC/aix32-frames-stack-floor.ll:1
+; RUN: llc -verify-machineinstrs < %s -mcpu=pwr4 -mattr=-altivec \
+; RUN: -mtriple=powerpc-ibm-aix-xcoff | FileCheck %s -check-prefix=PPC32-NOFP
----------------
ZarkoCA wrote:
> Nit: can you combine this and aix43-frames-stack-floor.ll in one file? 
The testcase for 32bit and 64bit are different in terms of how much bytes allocated will pass the stack floor limit. So that's why I separate them out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72454/new/

https://reviews.llvm.org/D72454