[PATCH] D72974: [mlir] Fix LLVM intrinsic convesion generator for overloadable types.

[River Riddle via Phabricator via llvm-commits]

rriddle requested changes to this revision.
rriddle added inline comments.
This revision now requires changes to proceed.


================
Comment at: mlir/tools/mlir-tblgen/LLVMIRIntrinsicGen.cpp:47
+// represent overloadable types
+static IndicesTy getOverloadableTypeIdxs(const llvm::Record &record,
+                                         const char *listName) {
----------------
Remove all static functions from namespace scope.


================
Comment at: mlir/tools/mlir-tblgen/LLVMIRIntrinsicGen.cpp:59
+    case llvm::MVT::vAny:
+      OverloadedOps.push_back(R.index());
+      break;
----------------
Use camelCase for variable names.


================
Comment at: mlir/tools/mlir-tblgen/LLVMIRIntrinsicGen.cpp:179
+    os << "\n        opInst.getOpOperand(" << idx << ").get().getType()"
+       << ".dyn_cast<LLVM::LLVMType>().getUnderlyingType(),";
+  }
----------------
Use cast if the result isn’t being check for null.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72974/new/

https://reviews.llvm.org/D72974