[PATCH] D72280: [Matrix] Add IR MatrixBuilder.

[Adam Nemet via Phabricator via llvm-commits]

anemet accepted this revision.
anemet added a comment.
This revision is now accepted and ready to land.

LGTM, however it would better if this patch also converted existing code to use this new API.



================
Comment at: llvm/include/llvm/IR/MatrixBuilder.h:152-155
+    if (RHS->getType()->isFloatingPointTy())
+      return B.CreateFMul(LHS, ScalarVector);
+
+    return B.CreateMul(LHS, ScalarVector);
----------------
Should probably call CreateMul.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72280/new/

https://reviews.llvm.org/D72280