[PATCH] D72948: Unconditionally enable lvalue function designators; NFC

Aaron Ballman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 17 12:47:35 PST 2020


aaron.ballman created this revision.
aaron.ballman added reviewers: dblaikie, rsmith, zturner, echristo.
Herald added a subscriber: dexonsmith.
Herald added a project: LLVM.

We previously had to guard against older MSVC and GCC versions which had rvalue references but not support for marking functions with ref qualifiers. However, having bumped our minimum required version to MSVC 2017 and GCC 5.1 mean we can unconditionally enable this feature. Rather than keeping the macro around, this replaces use of the macro with the actual ref qualifier.

I tested with my copy of MSVC 2017, but I am not on the base release of 2017, so additional testing would be appreciated to verify the patch.


https://reviews.llvm.org/D72948

Files:
  clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExplodedGraph.h
  llvm/include/llvm/ADT/Optional.h
  llvm/include/llvm/ADT/PointerIntPair.h
  llvm/include/llvm/Support/Compiler.h
  llvm/unittests/ADT/OptionalTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72948.238856.patch
Type: text/x-patch
Size: 7234 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200117/facf89db/attachment.bin>


More information about the llvm-commits mailing list