[PATCH] D71307: [Loads] Handle simple cases with same base pointer with constant offsets in FindAvailableLoadedValue when AA is null.

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

(just passing-by remark)

In D71307#1792951 <https://reviews.llvm.org/D71307#1792951>, @yamauchi wrote:

> I believe if I request AA in Inliner.cpp and pass it down to FindAvailableLoadedValue through tryPromoteCall (D71308 <https://reviews.llvm.org/D71308>), it would work without this patch.
>
> Is it okay to assume that a) the AA is BasicAA and b) BasicAA is stateless since the AA interface is more generic? Is there a way to condition this logic on those conditions?


Perhaps it may be more productive to explain why this `This is a simple form of alias analysis.` *has* to exist?
Why can't, as suggested, BasicAA be used? What goes wrong if BasicAA is used?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71307/new/

https://reviews.llvm.org/D71307