[PATCH] D72938: Fix an assertion failure in DwarfExpression's subregister composition

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 17 10:51:53 PST 2020


aprantl created this revision.
aprantl added reviewers: vsk, djtodoro, markus, bjope.
aprantl added a project: debug-info.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.

This patch fixes an assertion failure in DwarfExpression that is triggered when a complex fragment has exactly
the size of a subregister of the register the DBG_VALUE points to *and* there is no DWARF encoding for the super-register.

I took the opportunity to replace/document some magic values with static constructor functions to make this code less confusing to read.

rdar://problem/58489125


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72938

Files:
  llvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp
  llvm/lib/CodeGen/AsmPrinter/DwarfExpression.h
  llvm/test/DebugInfo/MIR/ARM/subregister-full-piece.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72938.238823.patch
Type: text/x-patch
Size: 6073 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200117/f50fc8d1/attachment.bin>


More information about the llvm-commits mailing list