[llvm] 10d0e28 - [InstCombine] Split assume test in expensive and not; NFC

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 17 09:01:14 PST 2020


Author: Nikita Popov
Date: 2020-01-17T17:57:59+01:00
New Revision: 10d0e2882bbed5865e9716f6a091dd39facb02d9

URL: https://github.com/llvm/llvm-project/commit/10d0e2882bbed5865e9716f6a091dd39facb02d9
DIFF: https://github.com/llvm/llvm-project/commit/10d0e2882bbed5865e9716f6a091dd39facb02d9.diff

LOG: [InstCombine] Split assume test in expensive and not; NFC

The IR difference in @icmp1 serves as a test for D72864.

Added: 
    

Modified: 
    llvm/test/Transforms/InstCombine/assume.ll

Removed: 
    


################################################################################
diff  --git a/llvm/test/Transforms/InstCombine/assume.ll b/llvm/test/Transforms/InstCombine/assume.ll
index 8fabded56de3..a9bdce7f6a07 100644
--- a/llvm/test/Transforms/InstCombine/assume.ll
+++ b/llvm/test/Transforms/InstCombine/assume.ll
@@ -1,5 +1,6 @@
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
-; RUN: opt < %s -instcombine -S | FileCheck %s
+; RUN: opt < %s -instcombine -S | FileCheck %s --check-prefixes=CHECK,EXPENSIVE-ON
+; RUN: opt < %s -instcombine -expensive-combines=0 -S | FileCheck %s --check-prefixes=CHECK,EXPENSIVE-OFF
 target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
 target triple = "x86_64-unknown-linux-gnu"
 
@@ -189,10 +190,16 @@ entry:
 }
 
 define i32 @icmp1(i32 %a) #0 {
-; CHECK-LABEL: @icmp1(
-; CHECK-NEXT:    [[CMP:%.*]] = icmp sgt i32 [[A:%.*]], 5
-; CHECK-NEXT:    tail call void @llvm.assume(i1 [[CMP]])
-; CHECK-NEXT:    ret i32 1
+; EXPENSIVE-ON-LABEL: @icmp1(
+; EXPENSIVE-ON-NEXT:    [[CMP:%.*]] = icmp sgt i32 [[A:%.*]], 5
+; EXPENSIVE-ON-NEXT:    tail call void @llvm.assume(i1 [[CMP]])
+; EXPENSIVE-ON-NEXT:    ret i32 1
+;
+; EXPENSIVE-OFF-LABEL: @icmp1(
+; EXPENSIVE-OFF-NEXT:    [[CMP:%.*]] = icmp sgt i32 [[A:%.*]], 5
+; EXPENSIVE-OFF-NEXT:    tail call void @llvm.assume(i1 [[CMP]])
+; EXPENSIVE-OFF-NEXT:    [[CONV:%.*]] = zext i1 [[CMP]] to i32
+; EXPENSIVE-OFF-NEXT:    ret i32 1
 ;
   %cmp = icmp sgt i32 %a, 5
   tail call void @llvm.assume(i1 %cmp)
@@ -331,9 +338,16 @@ define i1 @nonnull5(i32** %a) {
 ; PR35846 - https://bugs.llvm.org/show_bug.cgi?id=35846
 
 define i32 @assumption_conflicts_with_known_bits(i32 %a, i32 %b) {
-; CHECK-LABEL: @assumption_conflicts_with_known_bits(
-; CHECK-NEXT:    tail call void @llvm.assume(i1 false)
-; CHECK-NEXT:    ret i32 0
+; EXPENSIVE-ON-LABEL: @assumption_conflicts_with_known_bits(
+; EXPENSIVE-ON-NEXT:    tail call void @llvm.assume(i1 false)
+; EXPENSIVE-ON-NEXT:    ret i32 0
+;
+; EXPENSIVE-OFF-LABEL: @assumption_conflicts_with_known_bits(
+; EXPENSIVE-OFF-NEXT:    [[AND1:%.*]] = and i32 [[B:%.*]], 3
+; EXPENSIVE-OFF-NEXT:    tail call void @llvm.assume(i1 false)
+; EXPENSIVE-OFF-NEXT:    [[CMP2:%.*]] = icmp eq i32 [[AND1]], 0
+; EXPENSIVE-OFF-NEXT:    tail call void @llvm.assume(i1 [[CMP2]])
+; EXPENSIVE-OFF-NEXT:    ret i32 0
 ;
   %and1 = and i32 %b, 3
   %B1 = lshr i32 %and1, %and1


        


More information about the llvm-commits mailing list