[PATCH] D72916: [IPO] Don't run jump threading at Oz

Kazu Hirata via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 17 08:46:52 PST 2020


kazu added a comment.

I echo what other have said.

- I'm curious about numbers.

- The new pass manager should be kept in sync.

- Jump threading could reduce code size in certain cases.  If we have:

  if (cond1) { A; } else { B; } if (cond1) { C; } else { D; }

  Then jump threading could eliminate the merge point (that is, the second "if") and produce:

  if (cond1) { A; C; } else  { B; D; }

  It should just be matter of adjusting the cost calculation to disallow size growth.

- That said, I'm OK with this change if numbers justify.  We can always revisit this pass and look into jump threading opportunities with size in mind.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72916/new/

https://reviews.llvm.org/D72916





More information about the llvm-commits mailing list