[PATCH] D72586: [MLIR] Move from add_llvm_library to add_llvm_component_library

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

> In D72586#1826339 <https://reviews.llvm.org/D72586#1826339>, @vchuravy wrote:
> 
>> Yes I think a libMLIR.so is the right choice, the only reason to go the other way would be if LLVM starts depending on MLIR.

This isn't a possibility to exclude entirely though, it'd be better if we don't add hurdles now to this future possibility.

>> LTO is split out into its own library.

I believe that this is a different situation: the LTO library is always built as a shared library because it a linker plugin. It also exposes a very specific API for this purpose: it is a different product entirely.
The LLVM shared library on the other hand is an alternative to the static libraries.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72586/new/

https://reviews.llvm.org/D72586