[PATCH] D72928: [llvm-exegesis][NFC] Disassociate snippet generators from benchmark runners

[Miloš Stojanović via Phabricator via llvm-commits]

mstojanovic marked 2 inline comments as done.
mstojanovic added inline comments.
Herald added a subscriber: wuzish.


================
Comment at: llvm/tools/llvm-exegesis/lib/ParallelSnippetGenerator.cpp:18-20
 // Ideally we would like the only limitation on executing uops to be the issue
 // ports. Maximizing port pressure increases the likelihood that the load is
 // distributed evenly across possible ports.
----------------
I'm not sure how this can be reworded to reflect that it deals with parallel instructions in general rather than just the uops case.


================
Comment at: llvm/tools/llvm-exegesis/lib/SerialSnippetGenerator.cpp:11-19
-#include "Assembler.h"
-#include "BenchmarkRunner.h"
 #include "MCInstrDescView.h"
-#include "PerfHelper.h"
-#include "Target.h"
-#include "llvm/ADT/STLExtras.h"
-#include "llvm/MC/MCInst.h"
----------------
It's not easy to determine which headers are needed here when splitting the files. Most of them seem to be unused.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72928/new/

https://reviews.llvm.org/D72928