[PATCH] D72899: [MC] Set sh_link to 0 if the associated symbol is undefined

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 17 07:27:37 PST 2020


peter.smith added a comment.

The implementation looks good to me. Will defer to others that know -fsanitize-coverage=inline-8bit-counters and LTO better. There was a comment in the PR about adding a dummy non-gcable section instead, I think that this would have the same effect as having the linker handle sh-link == 0, but it might be more portable to other linkers. Any thoughts on whether a dummy section would work better?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72899/new/

https://reviews.llvm.org/D72899





More information about the llvm-commits mailing list