[PATCH] D72602: [IndVarSimplify][LoopUtils] rewriteLoopExitValues. NFC.

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 17 06:11:16 PST 2020


dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

This looks useful as a separate function, the interface looks pretty clean and I think it lives nicely in LoopUtils.

LGTM.



================
Comment at: llvm/lib/Transforms/Scalar/IndVarSimplify.cpp:2692
+                                             ReplaceExitValue, DeadInsts)) {
+      NumReplaced = Rewrites;
+      Changed |= NumReplaced;
----------------
NumReplaced += Rewrites; maybe?


================
Comment at: llvm/lib/Transforms/Scalar/IndVarSimplify.cpp:2693
+      NumReplaced = Rewrites;
+      Changed |= NumReplaced;
+    }
----------------
Changed = true at this point.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72602/new/

https://reviews.llvm.org/D72602





More information about the llvm-commits mailing list