[PATCH] D72141: [mlir][spirv] Fix ADDITIONAL_HEADER_DIRS for SPIR-V libraries

[Lei Zhang via Phabricator via llvm-commits]

antiagainst marked an inline comment as done.
antiagainst added inline comments.


================
Comment at: mlir/lib/Dialect/SPIRV/Transforms/CMakeLists.txt:6
+  ADDITIONAL_HEADER_DIRS
+  ${MLIR_MAIN_INCLUDE_DIR}/mlir/Dialect/SPIRV
   )
----------------
mehdi_amini wrote:
> Why is this needed?
> 
> The build is passing for me without this. I can't find where a header would be included from one of these source files?
This is not needed for build. It is for aiding IDEs if I understand the original intent of `ADDTIONAL_HEADERS_DIRS` correctly (https://reviews.llvm.org/D7460). This is also to be consistent with other CMakeLists.txt we have in MLIR.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72141/new/

https://reviews.llvm.org/D72141