[PATCH] D71837: [ARM][MVE] Tail Predicate IsSafeToRemove

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 17 02:06:17 PST 2020


SjoerdMeijer added inline comments.


================
Comment at: llvm/test/CodeGen/Thumb2/LowOverheadLoops/vctp-subri.mir:147
+    renamable $r2, renamable $q1 = MVE_VLDRWU32_post killed renamable $r2, 16, 1, renamable $vpr :: (load 16 from %ir.lsr.iv1416, align 4)
+    renamable $r3 = t2SUBri killed renamable $r3, 4, 14, $noreg, $noreg
+    renamable $q0 = nsw MVE_VADDi32 killed renamable $q1, killed renamable $q0, 0, $noreg, undef renamable $q0
----------------
are we testing t2subri3 here?


================
Comment at: llvm/test/CodeGen/Thumb2/LowOverheadLoops/wlstp.mir:365
     renamable $r0, dead $cpsr = tADDi8 killed renamable $r0, 16, 14, $noreg
     renamable $r3, dead $cpsr = tSUBi8 killed renamable $r3, 8, 14, $noreg
     renamable $lr = t2LoopDec killed renamable $lr, 1
----------------
Ah, here's tSUBi8. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71837/new/

https://reviews.llvm.org/D71837





More information about the llvm-commits mailing list