[PATCH] D70837: [RISCV] Support ABI checking with per function target-features

[Kuan Hsu Chen (Zakk) via Phabricator via llvm-commits]

khchen added a comment.

In D70837#1824682 <https://reviews.llvm.org/D70837#1824682>, @RKSimon wrote:

> @khchen We have a load of EXPENSIVE_CHECKS RISCV MC + asm failures, a lot of which appear to be related to these changes to RISCVAsmParser please can you take a look?
>
> First appeared:
>  http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/21599/
>
> Current:
>  http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/21630/steps/test-check-all/logs/stdio


Sorry, this is my bug. 
I revert it https://reviews.llvm.org/rGcef838e65f9a2aeecf5e19431077bc16b01a79fb
It passed LLVM_ENABLE_EXPENSIVE_CHECKS on linux so I didn't catch it, Sorry again.
The root cause is std::string::back shall not be called on empty strings.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70837/new/

https://reviews.llvm.org/D70837