[PATCH] D72891: Compute ORE, BPI, BFI in Loop passes.

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 16 16:50:23 PST 2020


asbirlea created this revision.
asbirlea added reviewers: chandlerc, dmgreen, jdoerfert, reames.
Herald added subscribers: dexonsmith, steven_wu, zzheng, hiraditya, mehdi_amini.
Herald added a project: LLVM.

Passes ORE, BPI, BFI are not being preserved by Loop passes, hence it
is incorrect to retrieve these passes as cached.
This patch makes the loop passes in question compute a new instance.

In some of these cases, however, it may be beneficial to change the Loop pass to
a Function pass instead, similar to the change for LoopUnrollAndJam.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D72891

Files:
  llvm/lib/Analysis/OptimizationRemarkEmitter.cpp
  llvm/lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp
  llvm/lib/Transforms/Scalar/LICM.cpp
  llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp
  llvm/lib/Transforms/Scalar/LoopPredication.cpp
  llvm/lib/Transforms/Scalar/LoopUnrollPass.cpp
  llvm/test/Other/new-pm-defaults.ll
  llvm/test/Other/new-pm-thinlto-defaults.ll
  llvm/test/Other/new-pm-thinlto-postlink-pgo-defaults.ll
  llvm/test/Other/new-pm-thinlto-postlink-samplepgo-defaults.ll
  llvm/test/Other/new-pm-thinlto-prelink-pgo-defaults.ll
  llvm/test/Other/new-pm-thinlto-prelink-samplepgo-defaults.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D72891.238662.patch
Type: text/x-patch
Size: 11046 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200117/f84e4912/attachment.bin>


More information about the llvm-commits mailing list