[PATCH] D72877: [FastISel] Lower `llvm.dbg.value(undef, ...` correctly.

[Davide Italiano via Phabricator via llvm-commits]

davide marked 2 inline comments as done.
davide added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/fastisel-debugvalue-undef.ll:4
+; Check that we emit a DBG_VALUE for the `@llvm.dbg.value` which has `undef` has first arg.
+; CHECK: DBG_VALUE $noreg, $noreg, !"MyStruct", !DIExpression(), debug-location !34
+
----------------
aprantl wrote:
> Can you drop the `!34`? It's not relevant anyway.
Sure!


================
Comment at: llvm/test/CodeGen/AArch64/fastisel-debugvalue-undef.ll:52
+!14 = !{!15, !17, !19}
+!15 = !DIImportedEntity(tag: DW_TAG_imported_module, scope: !12, entity: !16, file: !12)
+!16 = !DIModule(scope: null, name: "a", includePath: "/Users/local/lldb-swift-device/llvm-project/lldb/packages/Python/lldbsuite/test/lang/swift/swift_reference_counting")
----------------
aprantl wrote:
> You could drop all these by just pointing every type to the DIFile directly.
I really wish bugpoint was smart enough to do this transformation :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72877/new/

https://reviews.llvm.org/D72877