[PATCH] D72882: [scudo][standalone] WIP: make release interval configurable

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: compiler-rt/lib/scudo/standalone/primary64.h:190
+  void setReleaseToOsIntervalMs(s32 Interval) {
+    atomic_store(&ReleaseToOsIntervalMs, Interval, memory_order_release);
+  }
----------------
I don't think this release/acquire order does anything here. Replace with memory_order_relaxed?


================
Comment at: compiler-rt/lib/scudo/standalone/wrappers_c.inc:162
+        case 0:
+          value = 500;
+          break;
----------------
This value, and the one below, do not seem to match the description in https://android.googlesource.com/platform/bionic/+/master/docs/native_allocator.md

A comment explaining the choice of the values would be great.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72882/new/

https://reviews.llvm.org/D72882