[PATCH] D72884: [NFC] Factor out function to detect if an attribute has an argument.

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 16 16:02:39 PST 2020


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM with one small nit



================
Comment at: llvm/include/llvm/IR/Attributes.h:114
 
+  /// Return true iff and only if the attribute has an Argument.
+  static bool doesAttrKindHaveArgument(Attribute::AttrKind AttrKind);
----------------
Nit: `iff` means `if and only if` usually, just remove one `f`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72884/new/

https://reviews.llvm.org/D72884





More information about the llvm-commits mailing list