[PATCH] D72828: [DWARF5] Added support for emission of debug_macro section.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 16 08:57:08 PST 2020


aprantl added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1187
+      // attribute.
+      if (CUNode->getMacros()) {
+        if (getDwarfVersion() >= 5) {
----------------
this check is oddly redundant?


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:2772
 
+// Emit the header of a DWARF 5 macro section.
+static void emitMacroHeader(AsmPrinter *Asm, const DwarfDebug &DD,
----------------
///


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72828/new/

https://reviews.llvm.org/D72828





More information about the llvm-commits mailing list