[PATCH] D72818: [GlobalsModRef] Add invalidate method

Thu Jan 16 09:44:32 PST 2020

tejohnson added a comment.

In D72818#1824398 <https://reviews.llvm.org/D72818#1824398>, @asbirlea wrote:

> Not a bug fix, but a prerequisite for a change I'm working on for the new pass manager, requiring all passes to have an invalidate method.
>  I sent it for review to get another pair of eyes on the invalidate implementation in case I missed something.

Ok thanks. Can you add a comment to it explaining the rationale, I see that the existing invalidate methods tend to comment on when/why they are invalidated.
I'm unfortunately not very familiar with this aspect of the pass manager, but the change seems reasonable (I assume we were never invalidating before?).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72818/new/

https://reviews.llvm.org/D72818