[PATCH] D72479: [PowerPC][AIX] Make PIC the default relocation model for AIX

Steven Wan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 16 07:59:49 PST 2020


stevewan added inline comments.


================
Comment at: llvm/test/tools/llc/aix-pic-setting.ll:7
+
+; CHECK-EMPTY: {{^}}{{$}}
+; CHECK-NON-PIC: invalid relocation model, AIX only supports PIC.
----------------
hubert.reinterpretcast wrote:
> I think we are actually expecting no output on stderr:
> ```
> CHECK-EMPTY-NOT: {{.}}
> ```
> 
Thanks for noting. I tried to check for emptiness, but this look like the proper way of doing it. Also to avoid confusion, I'm omitting the `CHECK-EMPTY` prefix as it is already a predefined directive in FileCheck.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72479/new/

https://reviews.llvm.org/D72479





More information about the llvm-commits mailing list