[PATCH] D72347: [NFC][XCOFF] Refactor Csect creation into TargetLoweringObjectFile

[Jason Liu via Phabricator via llvm-commits]

jasonliu accepted this revision.
jasonliu added a comment.
This revision is now accepted and ready to land.

Other than some minor nits. LGTM.



================
Comment at: llvm/include/llvm/Target/TargetLoweringObjectFile.h:216
+  /// On targets that support function descriptors, return a section for the
+  /// descriptor given it's symbol.
+  virtual MCSection *getSectionForFunctionDescriptor(const MCSymbol *S) const {
----------------
nit: it's -> its


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1980
+
+  return TCEntry;
+}
----------------
nit: similar to the function above, we could return this TCEntry directly without creating a local variable. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72347/new/

https://reviews.llvm.org/D72347