[PATCH] D72225: Align branches within 32-Byte boundary(Prefix padding)

[annita.zhang via Phabricator via llvm-commits]

annita.zhang added a comment.

In D72225#1820978 <https://reviews.llvm.org/D72225#1820978>, @MaskRay wrote:

> Diff 21 is still incorrect. I'll give a reproduce.
>
>   (DATA16_PREFIX)
>   (LEA64r)
>   <--- Diff 21 can place cs (0x2e) here and break the General Dynamic TLS code sequence --->
>   <MCInst 851> (DATA16_PREFIX)
>   <MCInst 851> (DATA16_PREFIX)
>   <MCInst 2450> (REX64_PREFIX)
>   <MCInst 602 <MCOperand Expr:(__tls_get_addr at PLT)>> CALL64pcrel32
>


Pls. give us a C or assembly file to reproduce. Thx a lot.



================
Comment at: llvm/include/llvm/MC/MCAsmBackend.h:59
+  /// Check if the target need to do instruction alignment.
+  virtual bool needAlign(MCObjectStreamer &OS) const { return false; };
 
----------------
No semicolon in the end.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72225/new/

https://reviews.llvm.org/D72225