[PATCH] D72479: [PowerPC][AIX] Make PIC the default relocation model for AIX

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 15 20:34:06 PST 2020


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/test/tools/llc/aix-pic-setting.ll:1
+; RUN: llc -mtriple=powerpc-ibm-aix < %s 2>&1 | FileCheck --allow-empty --check-prefix=CHECK-EMPTY %s
+; RUN: llc -mtriple=powerpc-ibm-aix --relocation-model=pic < %s 2>&1 | FileCheck --allow-empty --check-prefix=CHECK-EMPTY %s
----------------
Replace `2>&1` with `2>&1 1>/dev/null` on the RUN lines using `CHECK-EMPTY`.


================
Comment at: llvm/test/tools/llc/aix-pic-setting.ll:7
+
+; CHECK-EMPTY: {{^}}{{$}}
+; CHECK-NON-PIC: invalid relocation model, AIX only supports PIC.
----------------
I think we are actually expecting no output on stderr:
```
CHECK-EMPTY-NOT: {{.}}
```



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72479/new/

https://reviews.llvm.org/D72479





More information about the llvm-commits mailing list