[PATCH] D72801: [CodeExtractor] Transfer debug info to extracted function

[Vedant Kumar via Phabricator via llvm-commits]

vsk added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/CodeExtractor.cpp:1440
+  //     point to a variable in the wrong scope.
+  SmallDenseMap<DINode *, DINode *> RemappedMetadata;
+  SmallVector<Instruction *, 4> DebugIntrinsicsToDelete;
----------------
aprantl wrote:
> Out of curiosity: anything that can be shared with CloneFunction here?
Unfortunately not. I actually looked into this before writing the patch, but most of what's needed here is specific to moving instructions from one function to another.


================
Comment at: llvm/lib/Transforms/Utils/CodeExtractor.cpp:1489
+  DIB.finalizeSubprogram(NewSP);
+  DIB.finalize();
+
----------------
aprantl wrote:
> I'm not sure you actually need to call this when you don't create any new types with cycles.
Removed, thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72801/new/

https://reviews.llvm.org/D72801