[PATCH] D72701: [Hexagon] Add support for Linux ABI.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 15 15:29:49 PST 2020


pcc added a comment.

In D72701#1823025 <https://reviews.llvm.org/D72701#1823025>, @sidneym wrote:

> In D72701#1822556 <https://reviews.llvm.org/D72701#1822556>, @pcc wrote:
>
> > I know almost nothing about Hexagon, but shouldn't this be determined by the target triple, or at least a target-feature?
>
>
> When the target is Linux the clang driver will add this option.


So shouldn't the code here be checking whether the target is Linux using `Triple::isOSLinux()` instead of adding a new option?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72701/new/

https://reviews.llvm.org/D72701





More information about the llvm-commits mailing list