[PATCH] D72780: [mlir][Linalg] Fix Linalg EDSC builders

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache marked an inline comment as done.
nicolasvasilache added inline comments.


================
Comment at: mlir/lib/Dialect/Linalg/EDSC/Builders.cpp:103
       [&] { regionBuilder(b.getBlock()->getArguments()); });
+  region.getBlocks().erase(region.begin());
+  assert(op->getNumRegions() == 1);
----------------
asaadaldien wrote:
> Does the builder create a new block instead of mutating region.begin that we have to clean up ? 
Yes, currently it does.
I can improve this by extending ScopedContext slightly I think.
This is because the mechanism predates regions and has not yet been updated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72780/new/

https://reviews.llvm.org/D72780