[PATCH] D72734: [VectorUtils] Rework the Vector Function Database (VFDatabase).

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

The fix seems sensible to me.



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorizationLegality.cpp:571
+/// the sense that it should be vectorized and then expanded in
+/// multiple scalarcalls. This is represented in the
+/// TLI via mappings that do not specify a vector name, as in the
----------------
nit: s/scalarcalls/scalar calls/


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorizationLegality.cpp:582
+  // Check that all known VFs are not associated to a vector
+  // function, i.e. the vector name is emty.
+  if (Scalarize)
----------------
nit: s/emty/empty/


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorizationLegality.cpp:585
+    for (unsigned VF = 2, WidestVF = TLI.getWidestVF(ScalarName);
+         VF <= WidestVF; VF *= 2) {
+      Scalarize &= !TLI.isFunctionVectorizable(ScalarName, VF);
----------------
nit: unnecessary curly braces.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72734/new/

https://reviews.llvm.org/D72734