[PATCH] D72763: [mlir][spirv] Use sybmolize functions in enum attribute predicates

Ben Vanik via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 15 09:15:49 PST 2020


benvanik requested changes to this revision.
benvanik added a comment.
This revision now requires changes to proceed.

sybmolize is a typo in the description :)



================
Comment at: mlir/include/mlir/Dialect/SPIRV/SPIRVBase.td:2967
     ]> {
+  let predicate = And<[
+    IntegerAttrBase<I32, "">.predicate,
----------------
optional: it would make this file more readable if this was instead a class; `let predicate = I32EnumAttrIsSymbolizable<"SelectionControl"> etc`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72763/new/

https://reviews.llvm.org/D72763





More information about the llvm-commits mailing list