[PATCH] D68685: [RISCV] Scheduler description for Rocket Core

[Sam Elliott via Phabricator via llvm-commits]

lenary added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVSchedule.td:105
+def ReadIM	  : SchedRead;	// 32 & 64-bit multiply
+def ReadID	  : SchedRead;	// 32 & 64-bit divide
----------------
HsiangKai wrote:
> shiva0217 wrote:
> > HsiangKai wrote:
> > > They are the only two SchedRead definitions. However, there is no place using them. I think you should specify more SchedRead types and associate these SchedRead to input operands in instruction definitions.
> > Will the SchedRead for input operands be added, so they could be used by ReadAdvance to describe forwarding rules?
> I also think so. I will add SchedRead for input operands.
I presume this patch is not yet ready to land because it is still missing `SchedRead` for most input operands? Do you expect to have those ready before the LLVM 10.0 branch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68685/new/

https://reviews.llvm.org/D68685