[PATCH] D71874: [llvm-readobj][test] - Cleanup SHT_RELR sections testing.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 15 07:44:44 PST 2020


grimar marked 2 inline comments as done.
grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/relr-relocs.test:87
+    Flags: [ SHF_ALLOC ]
+    OffsetsAndBitmaps: [ 0x0000000000010D60, 0x0000000000000103, 0x0000000000020000,
+                         0x00000000000F0501, 0x000A700550400009 ]
----------------
grimar wrote:
> jhenderson wrote:
> > This needs rebasing, right?
> I guess the dependency was needed to be landed first. Now it is.
> This needs rebasing, right?

Right. Sorry, I've missed it because had a strange git error during rebasing today and finally decided to recreate this patch for reposting.
This hide this issue from me: "OffsetsAndBitmaps" should have been renamed to "Entries". I've found it during pre-commit check-llvm run and fixed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71874/new/

https://reviews.llvm.org/D71874





More information about the llvm-commits mailing list